[libvirt] [PATCH] qemu: dump: Report better error when dumping VM with passthrough devices

[Martin Kletzander]

On Mon, Jul 07, 2014 at 10:05:22AM +0200, Peter Krempa wrote:
>For the regular dump operation we migrate the VM to a file. This won't
>work when the VM has passthrough devices assigned. Rather than reporting
>a cryptic error from qemu run our check whether it can be migrated.
>
>This does not influence the memory-only dump that is allowed with
>passthrough devices.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=874418
>---
> src/qemu/qemu_driver.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

ACK,

Martin

>diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>index 2d1aa9e..fe76d55 100644
>--- a/src/qemu/qemu_driver.c
>+++ b/src/qemu/qemu_driver.c
>@@ -3481,6 +3481,10 @@ doCoreDump(virQEMUDriverPtr driver,
>                              "memory-only dump"));
>             goto cleanup;
>         }
>+
>+        if (!qemuMigrationIsAllowed(driver, vm, vm->def, false, false))
>+            goto cleanup;
>+
>         ret = qemuMigrationToFile(driver, vm, fd, 0, path,
>                                   qemuCompressProgramName(compress), false,
>                                   QEMU_ASYNC_JOB_DUMP);
>--
>2.0.0
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140707/ee5364a2/attachment-0001.sig>