[libvirt] [PATCH] check for cfg->spiceTLS earlier in qemuProcessSPICEAllocatePorts

[Eric Blake]

On 07/09/2014 03:09 AM, Ján Tomko wrote:
> This saves a few lines of code and catches the error when:
> <spice autoport ='yes' defaultMode='any' ..>
>   <channel name='main' mode='secure'/>
> </spice>
> is specified with spice_tls = 0 in qemu.conf.
> 
> Instead of this error in qemuBuildGraphicsSPICECommandLine:
> error: unsupported configuration: spice secure channels set in XML
> configuration, but TLS port is not provided
> 
> an error is reported in qemuProcessSPICEAllocatePorts:
> error: unsupported configuration: Auto allocation of spice TLS port
> requested but spice TLS is disabled in qemu.conf
> 
> Inspired by:
> https://www.redhat.com/archives/libvir-list/2014-June/msg01408.html
> ---
>  src/qemu/qemu_process.c | 33 +++++++++++----------------------
>  1 file changed, 11 insertions(+), 22 deletions(-)

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140709/cd45d7fd/attachment-0001.sig>