[libvirt] [PATCH] qemu: blockcopy: Initialize correct source structure
Eric Blake
eblake at redhat.com
Tue Jul 15 13:24:27 UTC 2014
On 07/15/2014 02:35 AM, Peter Krempa wrote:
> 4cc1f1a01fb338de939ba88eb933931687b22336 introduced a crash when doing a
> block copy as virStorageSourceInitChainElement was called on
> "disk->mirror" that is still NULL at that point instead of "mirror"
> which temporarily holds the mirror source struct until it's fully
> initialized. This resulted into a crash as a NULL was dereferenced.
>
> Reported by: Shanzi Yu <shyu at redhat.com>
> ---
>
> Fortunately unreleased.
>
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
ACK
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 8d40bc9..c0ad446 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -15309,7 +15309,7 @@ qemuDomainBlockCopy(virDomainObjPtr vm,
> if (VIR_STRDUP(mirror->path, dest) < 0)
> goto endjob;
>
> - if (virStorageSourceInitChainElement(disk->mirror, disk->src, false) < 0)
> + if (virStorageSourceInitChainElement(mirror, disk->src, false) < 0)
> goto endjob;
>
> if (qemuDomainPrepareDiskChainElement(driver, vm, mirror,
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140715/b2d7ed32/attachment-0001.sig>
More information about the libvir-list
mailing list