[libvirt] [PATCH v3 04/16] conf, schema: add 'id' field for cells

[Eric Blake]

On 07/16/2014 08:42 AM, Martin Kletzander wrote:
> In XML format, by definition, order of fields should not matter, so
> order of parsing the elements doesn't affect the end result.  When
> specifying guest NUMA cells, we depend only on the order of the 'cell'
> elements.  With this patch all older domain XMLs are parsed as before,
> but with the 'id' attribute they are parsed and formatted according to
> that field.  This will be useful when we have tuning settings for
> particular guest NUMA node.

It's not always true that order doesn't matter - for the longest time,
the order of <disk> under <devices> determined boot order.  But I agree
that the flexibility of using an id to allow arbitrary ordering can be
nicer than enforcing constant ordering.

> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  docs/formatdomain.html.in                          | 17 +++++----
>  docs/schemas/domaincommon.rng                      |  5 +++

Looks okay to me on the schema side.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140716/3b4e9238/attachment-0001.sig>