[libvirt] [PATCH v3 08/16] conf, schema: add support for memnode elements

Eric Blake eblake at redhat.com
Wed Jul 16 18:43:07 UTC 2014


On 07/16/2014 12:33 PM, Martin Kletzander wrote:
> On Wed, Jul 16, 2014 at 12:21:24PM -0600, Eric Blake wrote:
>> On 07/16/2014 08:42 AM, Martin Kletzander wrote:
>>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>>> ---
> [...]

>>
>> Missing an <interleave> here (<memory> and <memnode> should be swappable
>> with one another).
>>
> 
> Oh!  My bad.  So sorry :-(
> 
> Good point, is this OK to push as trivial (git diff -w):

Count this as my ACK :)

> 
> diff --git i/docs/schemas/domaincommon.rng w/docs/schemas/domaincommon.rng
> index a0ea300..fb5bdb3 100644
> --- i/docs/schemas/domaincommon.rng
> +++ w/docs/schemas/domaincommon.rng
> @@ -790,6 +790,7 @@
>         </element>
>       </optional>
>       <zeroOrMore>
> +        <interleave>
>           <element name="memnode">

I'm assuming the odd spacing here is due to pasting into the email body,
not how it actually looked in the diff.  That, and diff -w already plays
games with spacing.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140716/faad4ce3/attachment-0001.sig>


More information about the libvir-list mailing list