[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 00/16] Support for per-guest-node binding



On 07/16/2014 04:42 PM, Martin Kletzander wrote:
> v3 of https://www.redhat.com/archives/libvir-list/2014-July/msg00372.html
> 
> v3:
>  - Michal's suggestions worked in
>  - rebased on current master
> 
> Martin Kletzander (16):
>   qemu: purely a code movement
>   qemu: remove useless error check
>   conf: purely a code movement
>   conf, schema: add 'id' field for cells
>   numatune: create new module for numatune
>   numatune: unify numatune struct and enum names
>   numatune: Encapsulate numatune configuration in order to unify results
>   conf, schema: add support for memnode elements
>   numatune: add support for per-node memory bindings in private APIs
>   qemu: allow qmp probing for cmdline options without params
>   qemu: memory-backend-ram capability probing
>   qemu: newer -numa parameter capability probing
>   qemu: enable disjoint numa cpu ranges
>   qemu: pass numa node binding preferences to qemu
>   qemu: split out cpuset.mems setting
>   qemu: leave restricting cpuset.mems after initialization
> 
>  docs/formatdomain.html.in                          |  32 +-
>  docs/schemas/domaincommon.rng                      |  22 +
>  po/POTFILES.in                                     |   1 +
>  src/Makefile.am                                    |   3 +-
>  src/conf/cpu_conf.c                                |  41 +-
>  src/conf/cpu_conf.h                                |   3 +-
>  src/conf/domain_conf.c                             | 203 ++-----
>  src/conf/domain_conf.h                             |  10 +-
>  src/conf/numatune_conf.c                           | 595 +++++++++++++++++++++
>  src/conf/numatune_conf.h                           | 108 ++++
>  src/libvirt_private.syms                           |  24 +-
>  src/lxc/lxc_cgroup.c                               |  20 +-
>  src/lxc/lxc_controller.c                           |   5 +-
>  src/lxc/lxc_native.c                               |  15 +-
>  src/parallels/parallels_driver.c                   |   7 +-
>  src/qemu/qemu_capabilities.c                       |  16 +-
>  src/qemu/qemu_capabilities.h                       |   2 +
>  src/qemu/qemu_cgroup.c                             |  52 +-
>  src/qemu/qemu_cgroup.h                             |   4 +-
>  src/qemu/qemu_command.c                            |  98 +++-
>  src/qemu/qemu_driver.c                             |  84 ++-
>  src/qemu/qemu_monitor.c                            |   6 +-
>  src/qemu/qemu_monitor.h                            |   3 +-
>  src/qemu/qemu_monitor_json.c                       |   8 +-
>  src/qemu/qemu_monitor_json.h                       |   3 +-
>  src/qemu/qemu_process.c                            |  12 +-
>  src/util/virnuma.c                                 |  61 +--
>  src/util/virnuma.h                                 |  28 +-
>  tests/qemucapabilitiesdata/caps_1.6.50-1.caps      |   1 +
>  tests/qemucapabilitiesdata/caps_1.6.50-1.replies   |   5 +
>  tests/qemumonitorjsontest.c                        |  20 +-
>  .../qemuxml2argv-cpu-numa-disjoint.args            |   6 +
>  .../qemuxml2argv-cpu-numa-disjoint.xml             |  28 +
>  tests/qemuxml2argvdata/qemuxml2argv-cpu-numa1.xml  |   6 +-
>  tests/qemuxml2argvdata/qemuxml2argv-cpu-numa2.xml  |   6 +-
>  tests/qemuxml2argvdata/qemuxml2argv-cpu-numa3.xml  |  25 +
>  .../qemuxml2argv-numatune-auto-prefer.xml          |  29 +
>  .../qemuxml2argv-numatune-memnode-no-memory.args   |   8 +
>  .../qemuxml2argv-numatune-memnode-no-memory.xml    |  30 ++
>  .../qemuxml2argv-numatune-memnode-nocpu.xml        |  25 +
>  .../qemuxml2argv-numatune-memnode.args             |  11 +
>  .../qemuxml2argv-numatune-memnode.xml              |  33 ++
>  .../qemuxml2argv-numatune-memnodes-problematic.xml |  31 ++
>  tests/qemuxml2argvtest.c                           |  12 +
>  .../qemuxml2xmlout-cpu-numa1.xml                   |  28 +
>  .../qemuxml2xmlout-cpu-numa2.xml                   |  28 +
>  .../qemuxml2xmlout-numatune-auto-prefer.xml        |  29 +
>  .../qemuxml2xmlout-numatune-memnode.xml            |  33 ++
>  tests/qemuxml2xmltest.c                            |   8 +
>  49 files changed, 1479 insertions(+), 389 deletions(-)
>  create mode 100644 src/conf/numatune_conf.c
>  create mode 100644 src/conf/numatune_conf.h
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-numa-disjoint.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-numa-disjoint.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-numa3.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-auto-prefer.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode-no-memory.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode-no-memory.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode-nocpu.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-memnodes-problematic.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-numa1.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-numa2.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-numatune-auto-prefer.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-numatune-memnode.xml
> 
> --
> 2.0.0
> 

This series broke the build for me (clang 3.4.1):
In file included from util/virclosecallbacks.c:28:
In file included from ../src/util/virclosecallbacks.h:28:
../src/conf/domain_conf.h:70:35: error: redefinition of typedef
'virDomainNumatune' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct _virDomainNumatune virDomainNumatune;
                                  ^
../src/conf/numatune_conf.h:43:35: note: previous definition is here
typedef struct _virDomainNumatune virDomainNumatune;
                                  ^
In file included from util/virclosecallbacks.c:28:
In file included from ../src/util/virclosecallbacks.h:28:
../src/conf/domain_conf.h:71:28: error: redefinition of typedef
'virDomainNumatunePtr' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef virDomainNumatune *virDomainNumatunePtr;
                           ^
../src/conf/numatune_conf.h:44:28: note: previous definition is here
typedef virDomainNumatune *virDomainNumatunePtr;
                           ^
In file included from util/virclosecallbacks.c:28:
In file included from ../src/util/virclosecallbacks.h:28:
../src/conf/domain_conf.h:1857:30: error: redefinition of typedef
'virDomainDef' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct _virDomainDef virDomainDef;
                             ^
../src/conf/numatune_conf.h:39:30: note: previous definition is here
typedef struct _virDomainDef virDomainDef;
                             ^
In file included from util/virclosecallbacks.c:28:
In file included from ../src/util/virclosecallbacks.h:28:
../src/conf/domain_conf.h:1858:23: error: redefinition of typedef
'virDomainDefPtr' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef virDomainDef *virDomainDefPtr;
                      ^
../src/conf/numatune_conf.h:40:23: note: previous definition is here
typedef virDomainDef *virDomainDefPtr;
                      ^
4 errors generated.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]