[libvirt] [PATCH 1/2] storage: Convert 'building' into a bool

John Ferlan jferlan at redhat.com
Thu Jul 17 18:10:47 UTC 2014


Rather than a unsigned int, use a 'bool' since that's how it was used.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/conf/storage_conf.h      | 2 +-
 src/storage/storage_driver.c | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index badf7a3..54c978d 100644
--- a/src/conf/storage_conf.h
+++ b/src/conf/storage_conf.h
@@ -63,7 +63,7 @@ struct _virStorageVolDef {
     char *key;
     int type; /* virStorageVolType */
 
-    unsigned int building;
+    bool building;
     unsigned int in_use;
 
     virStorageVolSource source;
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 441da21..3830867 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1691,7 +1691,7 @@ storageVolCreateXML(virStoragePoolPtr obj,
 
         /* Drop the pool lock during volume allocation */
         pool->asyncjobs++;
-        voldef->building = 1;
+        voldef->building = true;
         virStoragePoolObjUnlock(pool);
 
         buildret = backend->buildVol(obj->conn, pool, buildvoldef, flags);
@@ -1700,7 +1700,7 @@ storageVolCreateXML(virStoragePoolPtr obj,
         virStoragePoolObjLock(pool);
         storageDriverUnlock(driver);
 
-        voldef->building = 0;
+        voldef->building = false;
         pool->asyncjobs--;
 
         if (buildret < 0) {
@@ -1858,7 +1858,7 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj,
 
     /* Drop the pool lock during volume allocation */
     pool->asyncjobs++;
-    newvol->building = 1;
+    newvol->building = true;
     origvol->in_use++;
     virStoragePoolObjUnlock(pool);
 
@@ -1876,7 +1876,7 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj,
     storageDriverUnlock(driver);
 
     origvol->in_use--;
-    newvol->building = 0;
+    newvol->building = false;
     allocation = newvol->target.allocation;
     pool->asyncjobs--;
 
-- 
1.9.3




More information about the libvir-list mailing list