[libvirt] [PATCH 1/2] Refactor virMutexInit virRWLockInit and virCondInit

Eric Blake eblake at redhat.com
Fri Jul 18 13:28:45 UTC 2014


On 07/17/2014 10:49 PM, Jincheng Miao wrote:
> Implement InitInternal functions for Mutex, RWLock and Cond, these functions
> contain error report using virReportSystemErrorFull, it is controlled by
> an argument 'quite'.

s/quite/quiet/

> The related macros are Init and InitQuite, they call InitInternal function

s/InitQuite/InitQuiet/ - looks like you need to respin, as it's rather
pervasive.

> by passing 'false' or 'true' to quite argument.
> 
> Signed-off-by: Jincheng Miao <jmiao at redhat.com>
> ---
>  src/libvirt_private.syms |  7 ++--
>  src/util/virthread.c     | 95 ++++++++++++++++++++++++------------------------
>  src/util/virthread.h     | 57 ++++++++++++++++++++++-------
>  3 files changed, 94 insertions(+), 65 deletions(-)
> 

>  
> -void virMutexDestroy(virMutexPtr m)
> +void virMutexDestroy(virMutexPtr mutex)
>  {
> -    pthread_mutex_destroy(&m->lock);
> +    pthread_mutex_destroy(&mutex->lock);
>  }

Please separate trivial renamings into its own patch, so that this patch
can focus on the meat of new additions rather than having to hunt for
the real changes amidst the noise.



-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140718/4846159c/attachment-0001.sig>


More information about the libvir-list mailing list