[libvirt] [PATCH 5/8] Add virConnectPtr for qemuBuildSCSIHostdevDrvStr

Eric Blake eblake at redhat.com
Mon Jul 21 20:14:56 UTC 2014


On 07/11/2014 06:35 AM, John Ferlan wrote:
> Add a conn for future patches to be able to grab the secret when
> authenticating an iSCSI host device
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/qemu/qemu_command.c |  5 +++--
>  src/qemu/qemu_command.h |  5 +++--
>  src/qemu/qemu_driver.c  |  6 +++---
>  src/qemu/qemu_hotplug.c | 34 ++++++++++++++++++++--------------
>  src/qemu/qemu_hotplug.h |  9 ++++++---
>  5 files changed, 35 insertions(+), 24 deletions(-)

I'm not sure if our goal has been to get rid of passing the conn through
by having smarter callbacks, but if it is, this moves in the opposite
direction.  But this patch is clean code-wise, as long as there are no
major design concerns.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140721/c9a33b31/attachment-0001.sig>


More information about the libvir-list mailing list