[libvirt] [PATCH] spec: drop anything older than Fedora 13

Martin Kletzander mkletzan at redhat.com
Thu Jul 24 10:11:03 UTC 2014


On Wed, Jul 23, 2014 at 02:03:17PM -0600, Eric Blake wrote:
>Ping.
>

I'm not that skilled in spec files, but if you'd rebase it so it
applies onto current master (with changes from jdenemar), I'd my
convince myself to learn a bit more spec-magic and have a look at
it.

>On 07/15/2014 05:31 PM, Eric Blake wrote:
>> RHEL 5 is based on libvirt 0.8.2, as was Fedora 13.  RHEL 5 also
>> happens to be the oldest box that we actively support with a
>> buildbot, so it is time to clean up some crufty conditionals in
>> the spec file that no longer are necessary for modern Fedora.
>>
>> Although it is probably okay to make further simplifications to
>> a newer minimum Fedora version, that can be done as a later patch.
>> This patch just focuses on cleaning any comparison of %{?fedora}
>> that will always be true or false once we assume a minimum of F13.
>>
>> * libvirt.spec.in: Make with_audit default to on. Move other
>> conditionals to a single RHEL-5 block. Simplify any fedora
>> comparison older than 13.  Document our assumptions.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>  libvirt.spec.in | 69 ++++++++++++++++++++-------------------------------------
>>  1 file changed, 24 insertions(+), 45 deletions(-)
>>
[...]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140724/948860bf/attachment-0001.sig>


More information about the libvir-list mailing list