[libvirt] [PATCH] remove range checking for blkiotune weight

Ján Tomko jtomko at redhat.com
Thu Jul 24 14:51:43 UTC 2014


On 07/24/2014 04:46 PM, Martin Kletzander wrote:
> This was changed before:
> 
> https://www.redhat.com/archives/libvir-list/2013-October/msg00525.html
> 
> but not everywhere in the code.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1100769
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  src/lxc/lxc_driver.c   | 14 --------------
>  src/qemu/qemu_driver.c | 14 --------------
>  tools/virsh-domain.c   |  2 +-
>  tools/virsh.pod        |  5 +----
>  4 files changed, 2 insertions(+), 33 deletions(-)
> 

I'd rather leave the limits documented in the man page.

ACK without the following hunk.

Jan

> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 849ae31..f387ab7 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1824,13 +1824,10 @@ Specifying -1 as a value for these limits is interpreted as unlimited.
>  [[I<--config>] [I<--live>] | [I<--current>]]
> 
>  Display or set the blkio parameters. QEMU/KVM supports I<--weight>.
> -I<--weight> is in range [100, 1000]. After kernel 2.6.39, the value
> -could be in the range [10, 1000].
> 
>  B<device-weights> is a single string listing one or more device/weight
>  pairs, in the format of /path/to/device,weight,/path/to/device,weight.
> -Each weight is in the range [100, 1000], [10, 1000] after kernel 2.6.39,
> -or the value 0 to remove that device from per-device listings.
> +Specifying 0 for any weight removes that device from per-device listings.
>  Only the devices listed in the string are modified;
>  any existing per-device weights for other devices remain unchanged.
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140724/0249d520/attachment-0001.sig>


More information about the libvir-list mailing list