[libvirt] [PATCH V2 2/6] qemu: Introduce vgamem attribute for video model

Wang Rui moon.wangrui at huawei.com
Fri Jul 25 09:41:48 UTC 2014


On 2014/7/24 17:48, Pavel Hrdina wrote:

>> index e59ea4c..18d5c17 100644
>> --- a/src/libvirt_private.syms
>> +++ b/src/libvirt_private.syms
>> @@ -434,6 +434,7 @@ virDomainVcpuPinDel;
>>  virDomainVcpuPinFindByVcpu;
>>  virDomainVcpuPinIsDuplicate;
>>  virDomainVideoDefaultRAM;
>> +virDomainVideoDefaultVgamem;
>>  virDomainVideoDefaultType;
>>  virDomainVideoDefFree;
>>  virDomainVideoTypeFromString;
> 
> Move the virDomainVideoDefaultVgamem after virDomainVideoDefaultType
> and next time, please build the libvirt before posting patches.
> 
Sorry, my fault.
Next time make check and make syntax-check can help me to do better.

> Another thing, if you want to use some qemu device option, you should
> introduce new qemu capability and check if the option is available, so
> there should be three new capabilities for vga.vgamem_mb,
> vmvga.vgamem_mb and qxl.vgamem_mb.
> 

OK. Do you mean I should add capability check in virQEMUCapsComputeCmdFlags()?

like:
    if (strstr(help, "vgamem_mb="))
        virQEMUCapsSet(qemuCaps, QEMU_CAPS_VGA_VGAMEM_MB);






More information about the libvir-list mailing list