[libvirt] [PATCH] qemu: sound: Fix uninitialized model string

Peter Krempa pkrempa at redhat.com
Mon Jul 28 09:42:14 UTC 2014


Commit e5f36698e3efc3d258b2996c7423c47e05ec52b2 introduces a
false-positive build failure in the sound card model handling switch.
Initialize the model to NULL although the value should never be used.
---

Notes:
    Pushed under the build-breaker and trivial rules.

 src/qemu/qemu_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index cb3c584..beb8ca8 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4674,7 +4674,7 @@ qemuBuildSoundDevStr(virDomainDefPtr def,
                      virQEMUCapsPtr qemuCaps)
 {
     virBuffer buf = VIR_BUFFER_INITIALIZER;
-    const char *model;
+    const char *model = NULL;

     /* Hack for devices with different names in QEMU and libvirt */
     switch ((virDomainSoundModel) sound->model) {
-- 
2.0.0




More information about the libvir-list mailing list