[libvirt] [PATCH v6 2/2] blockcommit: turn on active commit

Peter Krempa pkrempa at redhat.com
Wed Jul 30 08:53:23 UTC 2014


On 07/30/14 06:05, Eric Blake wrote:
> With this in place, I can (finally!) now do:
> 
> virsh blockcommit $dom vda --shallow --verbose --pivot
> 
> and watch qemu shorten the backing chain by one, followed by
> libvirt automatically updating the dumpxml output, effectively
> undoing the work of virsh snapshot-commit --no-metadata --disk-only.
> Commit is SOOOO much faster than blockpull, when I'm still fairly
> close in time to when the temporary qcow2 wrapper file was created
> via a snapshot operation!
> 
> * src/qemu/qemu_driver.c (qemuDomainBlockCommit): Implement live
> commit.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 46 +++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 41 insertions(+), 5 deletions(-)
> 

ACK and I don't object to push this before rc2 as we already stretched
the feature freeze rules by pushing the NUMA series.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140730/d24edb53/attachment-0001.sig>


More information about the libvir-list mailing list