[libvirt] [PATCH] leaseshelper: Include locale.h
Daniel P. Berrange
berrange at redhat.com
Mon Jun 2 15:00:31 UTC 2014
On Mon, Jun 02, 2014 at 04:46:25PM +0200, Michal Privoznik wrote:
> The commit baafe668 introduces this new helper utility. As in all
> our programs, there's setlocale() called at the beginning of
> main(). However, this source file don't include locale.h file
> which causes build errors on some systems (e.g. mine).
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/network/leaseshelper.c | 1 +
> 1 file changed, 1 insertion(+)
ACK as a build-breaker fix
Since we clearly keep making this mistake over & over, do you
fancy adding a syntax-check rule which looks for any file which
calls 'setlocale' but does not include 'locale.h' ?
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list