[libvirt] [PATCH] Don't use AI_ADDRCONFIG when binding to wildcard addresses

[Ján Tomko]

On 05/30/2014 09:36 PM, Eric Blake wrote:
> On 05/30/2014 12:21 AM, Ján Tomko wrote:
> 
>>>> +    if (nodename &&
>>>> +        !(virSocketAddrParse(&tmp_addr, nodename, AF_UNSPEC) > 0 &&
>>>> +          virSocketAddrIsWildcard(&tmp_addr)))
>>>> +        hints.ai_flags = AI_ADDRCONFIG;
>>>
>>> Shouldn't this be |= ?
>>>
>>
>> Functionally it's the same, AI_PASSIVE is ignored if nodename is non-NULL.
>>
>> But it should be |= if we were using other flags.
> 
> Okay.  ACK to the patch, and safe to include in 1.2.5.
> 

Pushed with the |= change, although it's too late for 1.2.5 now.

Thanks for the review.

Jan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140602/7e09a9a4/attachment-0001.sig>