[libvirt] [libvirt-glib] [PATCH] build: fix race in vapi/ subdirectory
Eric Blake
eblake at redhat.com
Mon Jun 2 22:12:02 UTC 2014
[adding "glib" to subject line to possibly trigger some mail filters...]
On 06/02/2014 10:52 AM, Michael Catanzaro wrote:
> libvirt-gobject-1.0.vapi depends on libvirt-gconfig-1.0.vapi
> ---
> vapi/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vapi/Makefile.am b/vapi/Makefile.am
> index 0154104..af10e98 100644
> --- a/vapi/Makefile.am
> +++ b/vapi/Makefile.am
> @@ -17,7 +17,7 @@ libvirt-glib-1.0.vapi:
> $(top_builddir)/libvirt-glib/LibvirtGLib-1.0.gir
> --library libvirt-glib-1.0 \
> $<
>
> -libvirt-gobject-1.0.vapi:
> $(top_builddir)/libvirt-gobject/LibvirtGObject-1.0.gir
> libvirt-glib-1.0.vapi
> +libvirt-gobject-1.0.vapi:
> $(top_builddir)/libvirt-gobject/LibvirtGObject-1.0.gir
> libvirt-glib-1.0.vapi libvirt-gconfig-1.0.vapi
This hit the list with line-wrapping , making it a bit harder to tell
what changed. It's okay to use:
libvirt-gobject-1.0.vapi: \
dep1 dep2 \
dep3
instead of cramming it on one line longer than 80 columns, if that makes
it more legible. I'm not a regular libvirt-glib contributor, so I won't
push it, but the change (adding libvirt-gconfig-1.0.vapi as an
additional dependency) makes sense on the surface.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140602/77259e3b/attachment-0001.sig>
More information about the libvir-list
mailing list