[libvirt] [libvirt-glib] [PATCH] Remove #if 0's from libvirt-gobject-domain-snapshot

Christophe Fergeau cfergeau at redhat.com
Tue Jun 3 07:44:34 UTC 2014


On Sat, May 24, 2014 at 10:09:05AM +0200, Timm Bäder wrote:
> On 21.05, Daniel P. Berrange wrote:
> > On Tue, May 20, 2014 at 08:56:24PM +0200, Timm Bäder wrote:
> > > The code seems to be fine.
> > > ---
> > > 
> > > I'd like to use this code (in later patches). If anything is wrong
> > > with the current implementation, I'd like to know so I can fix it.
> > 
> > This is just historical cruft. IIRC, I had #if 0'd it, because at the
> > time I wrote this, virDomainSnapshotRef didn't exist, but this is long
> > since added.
> > 
> > 
> > Regards,
> > Daniel
> 
> Well, that's even better, thanks. Is that patch OK in its current form?

This looks good yes, ACK and will be pushed soon.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140603/43d6387d/attachment-0001.sig>


More information about the libvir-list mailing list