[libvirt] [PATCH v2 1/4] qemu: Remove interface backend only after frontend is gone

Peter Krempa pkrempa at redhat.com
Tue Jun 3 08:35:08 UTC 2014


On 06/03/14 10:22, Jiri Denemark wrote:
> [1] reported that we are removing network's backend too early. I didn't
> really get the reproducer but libvirt behaves strangely when a guest
> does not confirm the removal, e.g., it does not support PCI hotplug. In
> such case, detaching a network device leaves its frontend in place but
> removes the backend, which makes the device unusable for the guest.
> Moreover attaching the same device again succeeds and both the guest and
> libvirt will see two network interfaces attached but only one of them is
> actually working.
> 
> I checked with Paolo Bonzini and he confirmed we should only remove a
> backend after seeing DEVICE_DELETED event for a corresponding frontend.
> 
> [1] https://www.redhat.com/archives/libvir-list/2014-March/msg01740.html
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
> 
> Notes:
>     Version 2:
>     - return int and propagate errors
> 
>  src/qemu/qemu_hotplug.c | 68 +++++++++++++++++++++++++++----------------------
>  1 file changed, 37 insertions(+), 31 deletions(-)
> 

ACK

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140603/5c3b5a1e/attachment-0001.sig>


More information about the libvir-list mailing list