[libvirt] [PATCH] qemu: monitor: Fix type of holdtime argument in qemuMonitorJSONSendKey

[Peter Krempa]

On 06/03/14 14:23, Martin Kletzander wrote:
> On Tue, Jun 03, 2014 at 11:37:45AM +0200, Peter Krempa wrote:
>> qemuMonitorJSONSendKey declares the "holdtime" argument as unsigned int
>> while the command was constructed in qemuMonitorJSONMakeCommand using
>> the "P" modifier which took a unsigned long from the variable
>> arguments which then made it possible to access uninitialized memory.
>>
>> This broke the qemumonitorjsontest on 32bit fedora 20:
>> 64) qemuMonitorJSONSendKey
>> ... libvirt: QEMU Driver error : internal error: unsupported data type
>> 'W' for arg 'WVSƒì ‹D$0è‘wÿÿÃAå' FAILED
>>
>> Uncovered by upstream commit f744b831c66d9e82453f7a96cab5eddf7570c253.
>>
>> Additionally add test for the hold-time option.
>> ---
>> src/qemu/qemu_monitor_json.c |  2 +-
>> tests/qemumonitorjsontest.c  | 33 +++++++++++++++++++++++++++++++++
>> 2 files changed, 34 insertions(+), 1 deletion(-)
>>
> 
> Makes sense, ACK.
> 
> Martin

Pushed; Thanks.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140603/faba684f/attachment-0001.sig>