[libvirt] [PATCH 1/2] vircapstest: Introduce basic testing

[Michal Privoznik]

On 05.06.2014 11:58, Daniel P. Berrange wrote:
> On Wed, Jun 04, 2014 at 05:34:13PM +0200, Michal Privoznik wrote:
>> For now only one test is introduced. It's purpose in life
>> is to check we don't break NUMA host distances XML format.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>   tests/vircapsdata/vircaps-basic.xml | 66 +++++++++++++++++++++++++++++++
>>   tests/vircapstest.c                 | 77 ++++++++++++++++++++++++++++++++++++-
>>   2 files changed, 141 insertions(+), 2 deletions(-)
>>   create mode 100644 tests/vircapsdata/vircaps-basic.xml
>
> I'm wondering whether this should be in a separate vircapsxml2xmltest.c
> file. I was originally intending vircapstest.c to be more targetting
> testing of the APIs in the capabilities code, and it could be helpful
> when debugging failures if these two areas were separate.

vircapsxml2xml sounds like we are parsing virCaps from a file and then 
formatting them back which is not exactly what I'm doing here. How about 
vircaps2xmltest then?

Michal