[libvirt] [PATCH v3 2/2] maint: prohibit empty first lines

Martin Kletzander mkletzan at redhat.com
Fri Jun 6 09:20:33 UTC 2014


Based on discussion with Eric:

https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---

Notes:
    I've kept the first output (list of files) to stdout to sope with the
    rest of grep checks, but I have no problem changing it to stderr
    instead.

 cfg.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index b5f1fa2..10ad744 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -936,6 +936,13 @@ sc_require_locale_h:
 	halt='setlocale() requires <locale.h>'				\
 	  $(_sc_search_regexp)

+sc_prohibit_empty_first_line:
+	@awk 'BEGIN { fail=0; }						\
+	FNR == 1 { if ($$0 == "") { print FILENAME ":1:"; fail=1; } }	\
+	END { if (fail == 1) {						\
+	  print "$(ME): Prohibited empty first line" > "/dev/stderr";	\
+	} exit fail; }' $$($(VC_LIST_EXCEPT));
+
 # We don't use this feature of maint.mk.
 prev_version_file = /dev/null

@@ -1115,3 +1122,6 @@ exclude_file_name_regexp--sc_avoid_attribute_unused_in_header = \

 exclude_file_name_regexp--sc_prohibit_mixed_case_abbreviations = \
   ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.c)$$
+
+exclude_file_name_regexp--sc_prohibit_empty_first_line = \
+  ^(README|daemon/THREADS\.txt|src/esx/README|docs/library.xen|tests/vmwareverdata/fusion-5.0.3.txt)$$
-- 
2.0.0




More information about the libvir-list mailing list