[libvirt] [PATCH] vmware: make version parsing more robust

[Jean-Baptiste Rouault]

On Monday 28 April 2014 13:46:54 Ján Tomko wrote:
> On 04/09/2014 11:59 AM, Jean-Baptiste Rouault wrote:
> > Since commit d69415d4, vmware version is parsed from both stdout and
> > stderr. This patch makes version parsing work even if there is garbage
> > (libvirt debug messages for example) in the command output.
> 
> For libvirt's debug messages, we have virLogProbablyLogMessage that can
> check if the message matches libvirt's format.
> 
> Should we really ignore all garbage?

Honestly I don't know, but as of today the only garbage I saw there was from 
libvirt. Apart from the version string, I don't think there could be useful 
information in the command output.

Regards,

Jean-Baptiste

-- 
Jean-Baptiste ROUAULT
R&D Engineer - diateam : Architectes de l'information
Phone : +33 (0)2 98 050 050 Fax : +33 (0)2 98 050 051