[libvirt] [PATCH] vbox: fix compilation error

[Eric Blake]

On 06/10/2014 11:10 AM, Roman Bogorodskiy wrote:
> clang complains about possibly uninitialized variable:
> 
> vbox/vbox_snapshot_conf.c:1355:9: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>     if (!(xPathContext = xmlXPathNewContext(xml))) {
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> So init 'ret' with NULL.
> ---
>  src/vbox/vbox_snapshot_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK; you can push this sort of fix under the trivial build-breaker rule.

> 
> diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c
> index 4909665..9c78410 100644
> --- a/src/vbox/vbox_snapshot_conf.c
> +++ b/src/vbox/vbox_snapshot_conf.c
> @@ -1336,7 +1336,7 @@ virVBoxSnapshotConfGetRODisksPathsFromLibvirtXML(const char *filePath,
>  {
>      int result = -1;
>      size_t i = 0;
> -    char **ret;
> +    char **ret = NULL;
>      xmlDocPtr xml = NULL;
>      xmlXPathContextPtr xPathContext = NULL;
>      xmlNodePtr *nodes = NULL;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140610/2fe86bc6/attachment-0001.sig>