[libvirt] [PATCH] vbox: fix compilation error

Roman Bogorodskiy bogorodskiy at gmail.com
Tue Jun 10 17:31:26 UTC 2014


  Eric Blake wrote:

> On 06/10/2014 11:10 AM, Roman Bogorodskiy wrote:
> > clang complains about possibly uninitialized variable:
> > 
> > vbox/vbox_snapshot_conf.c:1355:9: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> >     if (!(xPathContext = xmlXPathNewContext(xml))) {
> >         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > So init 'ret' with NULL.
> > ---
> >  src/vbox/vbox_snapshot_conf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK; you can push this sort of fix under the trivial build-breaker rule.

Pushed, thanks!

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140610/b5f929a5/attachment-0001.sig>


More information about the libvir-list mailing list