[libvirt] [PATCH] vbox: fix compilation error

[Roman Bogorodskiy]

  Michal Privoznik wrote:

> On 10.06.2014 19:10, Roman Bogorodskiy wrote:
> > clang complains about possibly uninitialized variable:
> >
> > vbox/vbox_snapshot_conf.c:1355:9: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> >      if (!(xPathContext = xmlXPathNewContext(xml))) {
> >          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > So init 'ret' with NULL.
> 
> Okay, I must admit clang has cool error reporting. But in fact, ret may 
> be used uninitialized way before reaching this line - there are two 
> places before where conditional jump is possible. But I guess compiler 
> is not SA tool anyway, right?

Actually, it reported these cases as well:

https://dpaste.de/oDuE

I just decided to mention the first one as the cause of all the errors
here is the same.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140610/80f2d2f7/attachment-0001.sig>