[libvirt] [PATCH] storage: fix memory leak with encrypted images

Eric Blake eblake at redhat.com
Tue Jun 10 17:41:34 UTC 2014


On 06/09/2014 10:38 PM, Jim Fehlig wrote:
> Eric Blake wrote:
>> Jim Fehlig reported a regression found by libvirt-TCK tests:
>>

>> Commit 2279d560 converted a boolean into a pointer with the intent of
>> transferring that pointer out of a temporary object into the caller's
>> data structure.  The temporary structure meant that meta->encryption
>> was always NULL on entry, so we could get away with blindly allocating
>> the pointer when the header said so.  But later commits then tweaked
>> things to do backing chain detection in-place, rather than via a
>> temporary object; this has the net result that meta->encryption can be
>> non-NULL on entry.
> 
> For reference, bisected and found the 'later commit' you mentioned to be
> 
> commit 8823272d41a259c1246c05d89f40ad3614fba58c

Thanks for doing that bisect.

> 
> ACK.

I've improved the commit message and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140610/c8c41b94/attachment-0001.sig>


More information about the libvir-list mailing list