[libvirt] [PATCH v3 2/2] maint: prohibit empty first lines

[Eric Blake]

On 06/11/2014 12:54 AM, Martin Kletzander wrote:

>>> It started to fail for me with this change:
>>>
>>> prohibit_empty_first_line
>>> tools/libvirt_win_icon_16x16.ico:1:
>>
>> Hmm, it might be simpler just to globally exclude all image formats,
>> rather than repeating lists of image files in affected rules.
>>
> 
> Definitely.  It's weird, though, that I'm not seeing this problem.  Is
> it because I'm building on Linux?  Why didn't some test box we have
> fail as well?
> 

Correct - Linux wasn't seeing the failure, because on Linux, 'awk' is
GNU awk which gracefully handles embedded NUL bytes.  On FreeBSD, 'awk'
is a different implementation, which chokes on binary files; and the
resulting choke triggered a false positive in the syntax check.

>> but my thoughts are that we should really ditch those one-off exception
>> lists for graphic binary files, and instead modify this list:
>>
>> VC_LIST_ALWAYS_EXCLUDE_REGEX = \
>>  (^(HACKING|docs/(news\.html\.in|.*\.patch))|\.po)$$
>>
> 
> And this looks like the right way to go.  It would deal with possible
> future problems as well.  After figuring out the parentheses, I can
> ACK this to go in if you want.  I'm hoping to get to cleaning up the
> excludes one day.

It's in, now:
https://www.redhat.com/archives/libvir-list/2014-June/msg00473.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140611/62e8ff25/attachment-0001.sig>