[libvirt] [PATCH 1/2] storage: pool: Fix handling of errors on pool lookup failure

[Peter Krempa]

On 06/11/14 17:12, Ján Tomko wrote:
> On 06/05/2014 01:52 PM, Peter Krempa wrote:
>> Rework internal pool lookup code to avoid printing the raw UUID buffer
>> in the case a storage pool can't be found:
>>
>>  $ virsh pool-name e012ace0-0460-5810-39ef-1bce5fa5a4dd
>>  error: failed to get pool 'e012ace0-0460-5810-39ef-1bce5fa5a4dd'
>>  error: Storage pool not found: no storage pool with matching uuid à¬à`X9ï_¥¤Ý
>>
>> The rework is mostly done by switching the lookup code to the newly
>> introduced helper virStoragePoolObjFromStoragePoo
> 
> *Pool
> 
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1104993
>> ---
>>  src/storage/storage_driver.c | 263 +++++++++++++++----------------------------
>>  1 file changed, 90 insertions(+), 173 deletions(-)
> 
> ACK
> 
>>
>> diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
>> index 4f51517..c9916ff 100644
>> --- a/src/storage/storage_driver.c
>> +++ b/src/storage/storage_driver.c
>> @@ -287,8 +289,7 @@ storagePoolLookupByUUID(virConnectPtr conn,
>>                              NULL, NULL);
>>
>>   cleanup:
>> -    if (pool)
>> -        virStoragePoolObjUnlock(pool);
>> +    virStoragePoolObjUnlock(pool);
> 
> But IMO it would look neater with these no-op changes separated.

I've separated these cleanups into a separate patch and pushed both of
those.

> 
> Jan
> 

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140612/bbe8d3a0/attachment-0001.sig>