[libvirt] [PATCH] Increase the size of REMOTE_MIGRATE_COOKIE_MAX to REMOTE_STRING_MAX

Shivaprasad bhat shivaprasadbhat at gmail.com
Thu Jun 12 11:52:23 UTC 2014


Could someone please review?

Thanks,
Shiva

On Wed, May 28, 2014 at 6:12 PM, Shivaprasad G Bhat
<shivaprasadbhat at gmail.com> wrote:
> During guest migration, if the domain xml is bigger than 16384 which is
> easily possible for a guest with good number of disks, message encode fails
> for xdr_remote_domain_migrate_perform3_ret().
> So, Increase the COOKIE_MAX to STRING_MAX value.
>
> Signed-off-by: Shivaprasad G Bhat <shivaprasadbhat at gmail.com>
> ---
>  src/remote/remote_protocol.x |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index 1f9d583..ab9b83d 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -86,7 +86,7 @@ const REMOTE_VCPUINFO_MAX = 16384;
>  const REMOTE_CPUMAPS_MAX = 8388608;
>
>  /* Upper limit on migrate cookie. */
> -const REMOTE_MIGRATE_COOKIE_MAX = 16384;
> +const REMOTE_MIGRATE_COOKIE_MAX = 4194304;
>
>  /* Upper limit on lists of networks. */
>  const REMOTE_NETWORK_LIST_MAX = 16384;
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list




More information about the libvir-list mailing list