[libvirt] [PATCH] virNetDevGetLinkInfo: Don't report link speed if NIC's down

Daniel P. Berrange berrange at redhat.com
Fri Jun 13 08:30:01 UTC 2014


On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
> The kernel's more broken than one would think. Various drivers report
> various (usually spurious) values if the interface is down. While on
> some we experience -EINVAL when read()-ing the speed sysfs file, with
> other drivers we might get anything from 0 to UINT_MAX. If that's the
> case it's better to not report link speed. Well, the interface is down
> anyway.

Wow, that's really awful. I think that warrants a bug report against
the kernelt too since such inconsistency can't be useful to anyone.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list