[libvirt] [PATCHv4 07/21] tests: virstoragetest: Fix output when hitting errors
Peter Krempa
pkrempa at redhat.com
Fri Jun 13 08:59:54 UTC 2014
On 06/13/14 05:51, Eric Blake wrote:
> On 06/11/2014 05:45 AM, Peter Krempa wrote:
>> When the test is failing but the debug output isn't enabled the
>> resulting line would look ugly like and would not contain the actual
>> difference.
>>
>> TEST: virstoragetest
>> .................chain member 1!chain member 1!chain member 1!
>>
>> Store the member index in the actual checked string to hide this problem
>> ---
>> tests/virstoragetest.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> I know I'm going pretty slow through my review of the series, but didn't
> I already ACK this one? At any rate, this one's safe to put in now if
> it is easy to rebase (and I still have my own patch to this file coming
> up soon when I rework chain lookup, so I'm trying to miminize conflict
> churn).
>
Yeah, it was ACKed but needed to be rebased as the previous patch in
this series creates a conflict. I've rebased it now and pushed.
Thanks.
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140613/72c692d8/attachment-0001.sig>
More information about the libvir-list
mailing list