[libvirt] [PATCH 0/4] catch bogus 'blockcommit --base=a --top=a'

Eric Blake eblake at redhat.com
Fri Jun 13 16:31:09 UTC 2014


This patch series was first hinted at here:
https://www.redhat.com/archives/libvir-list/2014-June/msg00589.html

It fixes a minor bug that has existed since blockcommit was first
added, where we had an off-by-one that caused us to generate
different error messages in some cases where a user was passing an
impossible request to blockcommit (basically, we tried to filter
bogus cases up front to give a nice message, but missed one case
that resulted in reporting a different message from qemu instead).

I apologize in advance for the conflicts this creates with Peter's
pending series, but think that the testsuite is both more legible
and more thorough with the changes added in this series.  It's
split into several patches to make review easier.

And can I just add that it is annoying dealing with gcc's:
virstoragetest.c:1076:1: error: the frame size of 6608 bytes is larger than 4096 bytes [-Werror=frame-larger-than=]
(although I agree with the need for keeping that warning)

Eric Blake (4):
  storage: add alias for less typing
  storage: renumber lookup tests
  storage: better tests of lookup
  blockcommit: require base below top

 src/qemu/qemu_driver.c    |   3 +-
 src/util/virstoragefile.c |  33 +++++----
 tests/virstoragetest.c    | 184 ++++++++++++++++++++++++++++------------------
 3 files changed, 135 insertions(+), 85 deletions(-)

-- 
1.9.3




More information about the libvir-list mailing list