[libvirt] [PATCH] qemu: snapshot: Don't mark all block disks for metadata reuse

[Peter Krempa]

On 06/16/14 16:00, Eric Blake wrote:
> On 06/16/2014 06:29 AM, Peter Krempa wrote:
>> For block devices used as snapshot source the new snapshot code would
>> set the reuse flag. This inhibits to take snapshot without specially
>> preparing the block image before taking the snapshot.
>>
>> Fortunately this is not a regression as only the new way of specifying
>> snapshot source is affected.
>>
>> For the followin snapshot XML:
>>  <domainsnapshot>
>>    <disks>
>>      <disk name='vda' type='block'>
>>        <driver type='qcow2'/>
>>        <source dev="/dev/andariel/testsnap" />
>>      </disk>
>>    </disks>
>>  </domainsnapshot>
>>
>> You'd get:
>> error: internal error: unable to execute QEMU command 'transaction': Image is not in qcow2 format
>>
>> After this patch the snapshot is created successfully.
>> ---
>>  src/qemu/qemu_driver.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> ACK.
> 


Pushed; Thanks.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140616/455e9b78/attachment-0001.sig>