[libvirt] [PATCH 1/5] util: json: Unify function header formatting

Pavel Hrdina phrdina at redhat.com
Mon Jun 16 15:34:22 UTC 2014


On 16.6.2014 17:21, Peter Krempa wrote:
> Use consistent formatting of function headers:
> - two newlines separating functions
> - function return type on separate line
> - one argument per line
> ---
>  src/util/virjson.c | 287 +++++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 215 insertions(+), 72 deletions(-)
> 
> diff --git a/src/util/virjson.c b/src/util/virjson.c
> index 35a8252..af760a8 100644
> --- a/src/util/virjson.c
> +++ b/src/util/virjson.c
> @@ -63,7 +63,8 @@ struct _virJSONParser {
>  };
> 
> 
> -void virJSONValueFree(virJSONValuePtr value)
> +void
> +virJSONValueFree(virJSONValuePtr value)
>  {
>      size_t i;
>      if (!value || value->protect)
> @@ -97,7 +98,8 @@ void virJSONValueFree(virJSONValuePtr value)
>  }
> 
> 
> -virJSONValuePtr virJSONValueNewString(const char *data)
> +virJSONValuePtr
> +virJSONValueNewString(const char *data)
>  {
>      virJSONValuePtr val;
> 
> @@ -116,7 +118,9 @@ virJSONValuePtr virJSONValueNewString(const char *data)
>      return val;
>  }
> 
> -virJSONValuePtr virJSONValueNewStringLen(const char *data, size_t length)
> +
> +virJSONValuePtr
> +virJSONValueNewStringLen(const char *data, size_t length)

You've missed one function with two arguments.

[..]

ACK with the change above.

Pavel




More information about the libvir-list mailing list