[libvirt] [PATCH] blockjob: don't remove older-style mirror XML

Eric Blake eblake at redhat.com
Mon Jun 16 22:14:47 UTC 2014


On 06/16/2014 02:21 PM, John Ferlan wrote:
> On 06/16/2014 03:47 PM, Eric Blake wrote:
>> Commit 7c6fc39 introduced a regression in the XML produced for older
>> clients.  The argument at the time was that clients shouldn't be
>> depending on output-only data for something that is only going to
>> be triggered for a transient guest; but John Ferlan reported that
>> the automated testsuite was such a client.  It's better to be safe
>> than sorry by guaranteeing back-compat cruft.  Note that later
>> patches will be using <mirror> for active block commit, but there
>> we don't have to worry about back-compat.
>>

>>
> 
> virt-test/tp-libvirt "virsh.blockcopy" is once again happy...
> 
> Tks -
> 
> ACK

Pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140616/1344b3bf/attachment-0001.sig>


More information about the libvir-list mailing list