[libvirt] [PATCHv2 2/2] vbox: snapshot: Avoid memleaks in functions dealing with disk arrays

Peter Krempa pkrempa at redhat.com
Tue Jun 17 14:35:51 UTC 2014


On 06/17/14 16:33, Pavel Hrdina wrote:
> On 17.6.2014 13:32, Peter Krempa wrote:
>> In virVBoxSnapshotConfRemoveFakeDisks and
>> virVBoxSnapshotConfDiskIsInMediaRegistry the disk array constructed from
>> all the disks would be leaked at the end of the function and on
>> allocation errors. Also the temporary disk list would be leaked.
>>
>> Add a cleanup section and free the memory properly.
>>
>> Found by coverity.
>> ---
>>  src/vbox/vbox_snapshot_conf.c | 40 ++++++++++++++++++++++++++++++----------
>>  1 file changed, 30 insertions(+), 10 deletions(-)
>>
> 
> ACK
> 

Pushed; Thanks.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140617/b6f370c1/attachment-0001.sig>


More information about the libvir-list mailing list