[libvirt] [PATCH] vbox: fix a segfault when taking a snapshot

Eric Blake eblake at redhat.com
Wed Jun 18 03:38:06 UTC 2014


On 06/17/2014 02:28 AM, Yohan BELLEGUIC wrote:
> there is a segfault in the vbox driver when taking a snapshot in the
> following functions:
> - vboxDomainGetXMLDesc
> - vboxSnapshotGetReadWriteDisks
> - vboxSnapshotGetReadOnlyDisks
> 
> The virStorageSourcePtr in virDomainDiskDef was not correctly allocated.

Aha; this happened because your commits for adding vbox snapshots
(commit 4dc5d8f and friends) were written before my patch that redid
disk allocation (commit bc3f5f1) but applied after, and Dan didn't know
to rebase across the semantic difference.

> ---
>  src/vbox/vbox_tmpl.c |   24 ++++++++++++++++--------
>  1 file changed, 16 insertions(+), 8 deletions(-)

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140617/21196d3e/attachment-0001.sig>


More information about the libvir-list mailing list