[libvirt] [PATCH 2/2] vbox_snapshot_conf: fix wrong use of 'xmlSaveFormatFileEnc'

Pavel Hrdina phrdina at redhat.com
Wed Jun 18 13:19:50 UTC 2014


On 18.6.2014 15:11, Peter Krempa wrote:
> On 06/18/14 14:29, Pavel Hrdina wrote:
>> The function 'xmlSaveFormatFileEnc' has a last option to set
>> if you want to format dumped xml with whitespaces or not.
>>
>> Older libxml2, the one used in RHEL6, take this option as it is
>> but newer libxml2 check this option if it's true or not. This
>> small difference somehow makes things messy on RHEL6 and generated
>> xml had extra new line and extra whitespaces.
>>
>> We should pass 1 instead if -1 because the -1 confuses the libxml2.
>>
>> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>> ---
>>  src/vbox/vbox_snapshot_conf.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK,
> 
> Peter
> 
> 

Thanks, pushed

Pavel




More information about the libvir-list mailing list