[libvirt] [PATCH 1/2] conf: only accept capabilities mode hostdev in LXC.
Jincheng Miao
jmiao at redhat.com
Thu Jun 19 10:01:43 UTC 2014
----- Original Message -----
> No, the parser code is not supposed to do semantic validation like
> this. This kind of check should be done exclusively in the driver
> code which forms the command line args for the hypervisors which
> don't support it.
Oh, I just understand why there is no hypervisor type check in domain_conf.c.
I will move this check to qemuBuildCommandLine().
Thanks for your review.
Best wishes,
Jincheng Miao
>
>
> Regards,
> Daniel
> --
> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org -o- http://virt-manager.org :|
> |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
>
More information about the libvir-list
mailing list