[libvirt] [PATCH 4/5] interface: clean up virInterfaceDefParseXML
Eric Blake
eblake at redhat.com
Thu Jun 19 21:54:18 UTC 2014
On 06/19/2014 04:48 AM, Laine Stump wrote:
> the switch cases for the 4 different interface types had repetitive
> code which has now been pulled out as common. While touching those
> lines, some extra usage of "!= NULL" etc has been eliminated to make
> things more compact and inline with current coding practices.
>
> NB: parentIfType == VIR_INTERFACE_TYPE_LAST means that this is a
> toplevel interface (not a subordinate of a bridge or bond). Only
> toplevel interfaces can have a start mode, mtu, or IP address element.
> ---
> src/conf/interface_conf.c | 68 +++++++++++++----------------------------------
> 1 file changed, 18 insertions(+), 50 deletions(-)
>
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140619/d3665184/attachment-0001.sig>
More information about the libvir-list
mailing list