[libvirt] [PATCH 5/5] interface: clean up virInterfaceDefDevFormat
Eric Blake
eblake at redhat.com
Thu Jun 19 21:57:59 UTC 2014
On 06/19/2014 04:48 AM, Laine Stump wrote:
> This modifies the formatting function of virInterface to be a proper
> mirror of the parse function, including the addition of a
> "parentIfType" arg so that we can decide whether or not it is
> appropriate to emit the elements that are only in toplevel interfaces,
> as well as the <link> element (which isn't allowed for bridge
> interfaces).
>
> Since the restructuring of the code necessarily changes the order of
> some of the elements, some test case data had to be updated.
And hence your <interleave> cleanups in patch 1/5 :)
> ---
> src/conf/interface_conf.c | 52 ++++++++++++-------------
> tests/interfaceschemadata/bond.xml | 2 +-
> tests/interfaceschemadata/bridge-no-address.xml | 2 +-
> tests/interfaceschemadata/bridge.xml | 2 +-
> tests/interfaceschemadata/ethernet-dhcp.xml | 4 +-
> tests/interfaceschemadata/vlan.xml | 2 +-
> 6 files changed, 31 insertions(+), 33 deletions(-)
>
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140619/b222e8bb/attachment-0001.sig>
More information about the libvir-list
mailing list