[libvirt] [PATCH 03/10] util: storagefile: Introduce helper to free storage source perms

[John Ferlan]

On 06/20/2014 02:53 AM, Peter Krempa wrote:
> On 06/19/14 20:57, John Ferlan wrote:
>>
>>
>> On 06/19/2014 09:46 AM, Peter Krempa wrote:
>>> It will also be reused later.
>>> ---
>>>  src/util/virstoragefile.c | 16 ++++++++++++----
>>>  1 file changed, 12 insertions(+), 4 deletions(-)
>>>
>>
>>
>> Why is it that patches 1-3 do not update libvirt_private.syms to add new
>> src/util/vir* APIs, but some of the future patches do update, such as 4,
> 
> The functions added in 1-3 are used only in the utils module, especially
> in the storage source deep copy function and are not linked to from
> other modules and therefore the symbol export isn't really necessary.
> 
> I might add them if you insist, but I don't expect the functions to be
> linked to other modules any soon.
> 

No insistence from me - just curious.  It would only save you a step
later on I suppose.  Moot point now since they're pushed.

John