[libvirt] [PATCH 3/3] Add pkg-config files to allow deps to build against source tree

[Eric Blake]

On 06/20/2014 10:51 AM, Daniel P. Berrange wrote:
> When testing language bindings it is useful to be able to build
> them against an uninstalled libvirt source tree. Add a dummy
> set of pkg-config files to allow for this. This can be used by
> setting
> 
>   export PKG_CONFIG_PATH=/path/to/libvirt/git/src

Yay - we need to document this trick in libvirt-python.git as well.

> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  .gitignore             |  1 +
>  configure.ac           |  3 +++
>  src/Makefile.am        |  8 +++++++-
>  src/libvirt-lxc.pc.in  | 18 ++++++++++++++++++
>  src/libvirt-qemu.pc.in | 18 ++++++++++++++++++
>  src/libvirt.pc.in      | 23 +++++++++++++++++++++++
>  6 files changed, 70 insertions(+), 1 deletion(-)
>  create mode 100644 src/libvirt-lxc.pc.in
>  create mode 100644 src/libvirt-qemu.pc.in
>  create mode 100644 src/libvirt.pc.in
> 

> +++ b/src/Makefile.am
> @@ -45,7 +45,13 @@ AM_LDFLAGS =	$(DRIVER_MODULE_LDFLAGS)			\
>  		$(NO_INDIRECT_LDFLAGS)				\
>  		$(NULL)
>  
> -EXTRA_DIST = $(conf_DATA) util/keymaps.csv
> +EXTRA_DIST = \
> +		$(conf_DATA) \
> +		util/keymaps.csv \
> +		libvirt.pc \
> +		libvirt-qemu.pc \
> +		libvirt-lxc.pc \
> +		$(NULL)

NACK to this hunk - the .pc files should NOT be part of the tarball,
because they contain contents that depend on configure results, while
the tarball must be independent.  End users will get their own .pc file
as soon as they do ./configure && make.

ACK to the rest.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140620/2ffdfcc5/attachment-0001.sig>