[libvirt] [PATCH] LXC: trivially support flag VIR_DRV_FEATURE_TYPED_PARAM_STRING

Ján Tomko jtomko at redhat.com
Mon Jun 23 13:08:14 UTC 2014


On 06/23/2014 09:28 AM, Chen Hanxiao wrote:
> fix:
> virsh -c lxc:/// memtune DOMAIN
> error: Unable to get number of memory parameters
> error: unsupported flags (0x4) in function lxcDomainGetMemoryParameters
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  src/lxc/lxc_driver.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)


lxcDomainGetSchedulerParametersFlags will need a similar fix.

It seems commit 399394 (released in v1.2.2) introduced this when it marked
the LXC driver as supporting the option without marking it as supported in
these APIs.

> 
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index 06f3e18..6b170fe 100644
> --- a/src/lxc/lxc_driver.c
> +++ b/src/lxc/lxc_driver.c
> @@ -895,7 +895,11 @@ lxcDomainGetMemoryParameters(virDomainPtr dom,
>      size_t i;
>  
>      virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
> -                  VIR_DOMAIN_AFFECT_CONFIG, -1);
> +                  VIR_DOMAIN_AFFECT_CONFIG,
> +                  VIR_TYPED_PARAM_STRING_OKAY, -1);
> +
> +    /* We don't return strings, and thus trivially support this flag.  */
> +    flags &= ~VIR_TYPED_PARAM_STRING_OKAY;
>  
>      if (!(vm = lxcDomObjFromDomain(dom)))
>          goto cleanup;
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140623/2d1c7917/attachment-0001.sig>


More information about the libvir-list mailing list