[libvirt] [PATCH 3/3] Add pkg-config files to allow deps to build against source tree

[Daniel P. Berrange]

On Mon, Jun 23, 2014 at 09:15:19AM -0600, Eric Blake wrote:
> On 06/23/2014 02:52 AM, Daniel P. Berrange wrote:
> > On Fri, Jun 20, 2014 at 01:02:46PM -0600, Eric Blake wrote:
> >> On 06/20/2014 10:51 AM, Daniel P. Berrange wrote:
> >>> When testing language bindings it is useful to be able to build
> >>> them against an uninstalled libvirt source tree. Add a dummy
> >>> set of pkg-config files to allow for this. This can be used by
> >>> setting
> >>>
> >>>   export PKG_CONFIG_PATH=/path/to/libvirt/git/src
> >>
> >> Yay - we need to document this trick in libvirt-python.git as well.
> >>
> 
> >>> -EXTRA_DIST = $(conf_DATA) util/keymaps.csv
> >>> +EXTRA_DIST = \
> >>> +		$(conf_DATA) \
> >>> +		util/keymaps.csv \
> >>> +		libvirt.pc \
> >>> +		libvirt-qemu.pc \
> >>> +		libvirt-lxc.pc \
> >>> +		$(NULL)
> >>
> >> NACK to this hunk - the .pc files should NOT be part of the tarball,
> >> because they contain contents that depend on configure results, while
> >> the tarball must be independent.  End users will get their own .pc file
> >> as soon as they do ./configure && make.
> > 
> > Obviously that was meant to be the .pc.in files
> 
> Doesn't automake automatically ship any .in file that are required by
> their use in AC_CONFIG_FILES?  [I'd have to actually test 'make dist' to
> prove one way or the other.]  But if not, then yes, adding the .pc.in
> files to EXTRA_DIST is appropriate.

You're right, it isn't needed at all.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|