[libvirt] [PATCH 0/5] Outline of rewriting vbox driver, with common code support.

Michal Privoznik mprivozn at redhat.com
Tue Jun 24 13:27:58 UTC 2014


On 23.06.2014 06:25, Taowei wrote:
> Michal asked me to try working out a sample of vbox driver's common code. Here
> it is. As the PATCHv2 is pending, I merged it.
>
> Taowei (5):
>    define interface with vbox_common
>    a sample of vbox_common function : vboxInitialize
>    implement vboxUniformedAPI in vbox_tmpl.c and remove common codes
>    install vbox api register in vbox_driver
>    make new files be compiled by libvirt
>
>   po/POTFILES.in            |    1 +
>   src/Makefile.am           |    4 +-
>   src/vbox/vbox_common.c    |   89 ++++++++++++++++++++++++++++
>   src/vbox/vbox_common.h    |  108 ++++++++++++++++++++++++++++++++++
>   src/vbox/vbox_commondef.h |   32 ++++++++++
>   src/vbox/vbox_driver.c    |   35 +++++++++--
>   src/vbox/vbox_tmpl.c      |  142 +++++++++++++++++----------------------------
>   7 files changed, 316 insertions(+), 95 deletions(-)
>   create mode 100644 src/vbox/vbox_common.c
>   create mode 100644 src/vbox/vbox_common.h
>   create mode 100644 src/vbox/vbox_commondef.h
>

Unfortunately you're not outlining any rework of internal implementation 
of a public API. Can you just pick one so we can have an idea how 
exhaustive is that going to be?

Michal




More information about the libvir-list mailing list