[libvirt] [PATCHv5 05/19] tests: virstoragetest: Remove "expBackingStore" field

[Eric Blake]

On 06/19/2014 07:59 AM, Peter Krempa wrote:
> Now that we changed ordering of the stored metadata so that the backing
> store is described by the child element the test should reflect this
> change too.
> 
> Remove the expected backing store field as it's actually described by
> the next element in the backing chain, so there's no need for
> duplication.
> ---
>  tests/virstoragetest.c | 19 +++----------------
>  1 file changed, 3 insertions(+), 16 deletions(-)
> 

> @@ -315,12 +314,11 @@ struct testChainData
> 
>  static const char testStorageChainFormat[] =
>      "chain member: %zu\n"
> -    "store: %s\n"
> +    "path:%s\n"
>      "backingStoreRaw: %s\n"

Why no space after ':'?

>      "capacity: %lld\n"
>      "encryption: %d\n"
>      "relPath:%s\n"
> -    "path:%s\n"
>      "relDir:%s\n"

Oh - we have a mix of formats.  It might be nice to be consistent; but
as this format string is only ever used on failing tests, it doesn't
matter in the normal case of all tests passing.

ACK. Up to you if you want to tweak that string format.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140624/43919631/attachment-0001.sig>