[libvirt] [PATCH 2/2] virConnectCompareCPU: Introduce FAIL_INCOMPATIBLE flag

[Eric Blake]

On 06/25/2014 06:34 AM, Jiri Denemark wrote:
> The new VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE flag for
> virConnectCompareCPU can be used to get an error
> (VIR_ERR_CPU_INCOMPATIBLE) describing the incompatibility instead of the
> usual VIR_CPU_COMPARE_INCOMPATIBLE return code.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---

>   *
> - * Returns comparison result according to enum virCPUCompareResult
> + * Returns comparison result according to enum virCPUCompareResult. If
> + * VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE is used and @xmlDesc CPU is
> + * incompatible with host CPU, this function will return VIR_CPU_COMPARE_ERROR
> + * (instead of VIR_CPU_COMPARE_INCOMPATIBLE) and the error will use
> + * VIR_ERR_CPU_INCOMPATIBLE code the error message will provide more details
> + * about the incompatibility.

Reads better if you change the tail to:

the error will use the VIR_ERR_CPU_INCOMPATIBLE code with a message
providing more details about the incompatibility

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140625/7cf2a350/attachment-0001.sig>