[libvirt] [PATCHv3 12/26] qemu: cgroup: Add functions to set cgroup image stuff on individual imgs

Eric Blake eblake at redhat.com
Thu Jun 26 02:26:30 UTC 2014


On 06/25/2014 10:54 AM, Peter Krempa wrote:
> Add functions that will allow to set all the required cgroup stuff on
> individual images taking a virStorageSourcePtr. Also convert functions
> designed to setup whole backing chain to take advantage of the chagne.

s/chagne/change/

> ---
>  src/qemu/qemu_cgroup.c | 104 ++++++++++++++++++++++++-------------------------
>  src/qemu/qemu_cgroup.h |   3 ++
>  2 files changed, 55 insertions(+), 52 deletions(-)
> 

> +int
> +qemuSetImageCgroup(virDomainObjPtr vm,
> +                   virStorageSourcePtr src,
> +                   bool deny)

Bikeshedding: I would have named it 'bool allow' and flipped the logic
(that is, passing true to turn on the cgroup, false to turn it back
off).  What you have works, though, so I won't insist.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140625/681d56af/attachment-0001.sig>


More information about the libvir-list mailing list